Re: [PATCH 0/2] git-svn: use svn:global-ignores when creating .gitignores

From: Alex Galvin <agalvin@comqi.com>
Date: Jul 18, 2024, 19:59 UTC
Message-ID: <ba217f0c-68db-4e66-9397-c8819589371e@comqi.com>
In-Reply-To: <xmqqed7r3fyv.fsf@gitster.g>

On 2024-07-17 4:45 p.m., Junio C Hamano wrote:

Show 7 quoted lines

> Paying attention to the new property and get it reflected to
> .gitignore on Git side may be a reasonable solution, especially if
> we ignore older version of Subversion.  But I have a naïve question.
> If a new version of git-svn starts to rely on the new property that
> is only available in SVN 1.8, would it create problems with folks
> whose SVN installation does not understand it?  Would it cause
> problems to them?

I don't believe so. Git doesn't do anything to set these properties, it just reads and translates them into the format used by .gitignore. So users on old versions of SVN should not be affected, their servers will not have this property set anywhere.

Show 7 quoted lines

> Anyway, in this project, explanation of the problem the patches
> address, with the outline of the solution, should be in the proposed
> commit log message of the patches themselves, not just written in
> the cover letter.  Can you redo the proposed log messages of these
> two patches, where you have none in this iteration?
>
> Thanks.

Sure thing. An amended patchset is incoming.

Thanks, Alex