git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/6] t5570: remove trailing padding

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Nov 9, 2020, 00:09 UTC
Message-ID
<b9d7478ddd496e11d13d433c8ba1423f97881942.1604880566.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.784.git.1604880565.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

Two blocks in t5570 want to align the closing double quotes, padding with spaces if needed. Since the maximum length of those lines is defined by the branch name `master`, the upcoming rename to `main` would unalign the quotes.

But then, it is unclear how those aligned closing quotes should help readability anyway, so let's just remove that padding altogether.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t5570-git-daemon.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/t/t5570-git-daemon.sh b/t/t5570-git-daemon.sh
index 34487bbb8c..8f69a7854f 100755
--- a/t/t5570-git-daemon.sh
+++ b/t/t5570-git-daemon.sh
@@ -147,18 +147,18 @@ test_remote_error()
 }
 
 msg="access denied or repository not exported"
-test_expect_success 'clone non-existent' "test_remote_error    '$msg' clone nowhere.git    "
+test_expect_success 'clone non-existent' "test_remote_error    '$msg' clone nowhere.git"
 test_expect_success 'push disabled'      "test_remote_error    '$msg' push  repo.git master"
-test_expect_success 'read access denied' "test_remote_error -x '$msg' fetch repo.git       "
-test_expect_success 'not exported'       "test_remote_error -n '$msg' fetch repo.git       "
+test_expect_success 'read access denied' "test_remote_error -x '$msg' fetch repo.git"
+test_expect_success 'not exported'       "test_remote_error -n '$msg' fetch repo.git"
 
 stop_git_daemon
 start_git_daemon --informative-errors
 
-test_expect_success 'clone non-existent' "test_remote_error    'no such repository'      clone nowhere.git    "
+test_expect_success 'clone non-existent' "test_remote_error    'no such repository'      clone nowhere.git"
 test_expect_success 'push disabled'      "test_remote_error    'service not enabled'     push  repo.git master"
-test_expect_success 'read access denied' "test_remote_error -x 'no such repository'      fetch repo.git       "
-test_expect_success 'not exported'       "test_remote_error -n 'repository not exported' fetch repo.git       "
+test_expect_success 'read access denied' "test_remote_error -x 'no such repository'      fetch repo.git"
+test_expect_success 'not exported'       "test_remote_error -n 'repository not exported' fetch repo.git"
 
 stop_git_daemon
 start_git_daemon --interpolated-path="$GIT_DAEMON_DOCUMENT_ROOT_PATH/%H%D"
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin via GitGitGadget
Message 6 of 7 in “(Mostly whitespace) cleanups in preparation for renaming the default main branch”
  1. 0/6 (Mostly whitespace) cleanups in preparation for renaming the default main branchJohannes Schindelin via GitGitGadget, Nov 9, 2020
  2. 2/6 t3406: indent with tabs, not spacesJohannes Schindelin via GitGitGadget, Nov 9, 2020
  3. 3/6 t3427: adjust stale commentJohannes Schindelin via GitGitGadget, Nov 9, 2020
  4. 1/6 t1004: insert missing "branch" in a messageJohannes Schindelin via GitGitGadget, Nov 9, 2020
  5. 4/6 t5400,t5402: consistently indent with tabs, not with spacesJohannes Schindelin via GitGitGadget, Nov 9, 2020
  6. 5/6 t5570: remove trailing paddingJohannes Schindelin via GitGitGadget, Nov 9, 2020
  7. 6/6 t9603: use tabs for indentationJohannes Schindelin via GitGitGadget, Nov 9, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.