Re: commit-graph idea: warn when disabled for incompatible repositories

From: Derrick Stolee <stolee@gmail.com>
Date: Dec 18, 2018, 14:35 UTC
Message-ID: <b74bab07-dd77-5195-aaee-a324e9a6b824@gmail.com>
In-Reply-To: <CAEcj5uXJC3Za0YCyazJi82JdF-tLCDs5OrzCwyD8Y155GnJa6Q@mail.gmail.com>

On 12/18/2018 9:22 AM, Thomas Ferris Nicolaisen wrote:

> Hey there,

Hi, Thomas!

Show 15 quoted lines

> Accidentally, my first use-case was a local copy of a big repository
> (chromium source) that another developer had cloned shallow (I wasn't
> even aware of their clone being shallow at that point).
>
> After spending a little time trying to figure out why no commit-graph
> file was being created, I noticed that it worked just fine testing in
> a fresh git repo.
>
> Then I discovered the .git/shallow file in the big repo. So I did
> fetch --unshallow, and commit-graph started working. Taking a 20
> second log --graph operation down to less than a second (wooo!).
>
> I saw some recent release notes that mentions that commit-graph is
> disabled in incompatible repositories (graft, replace). I assume this
> also be the case for shallow clones.

The commit-graph feature is not designed to work well with these features, and the "easy" fix we have so far is to completely avoid the interaction. The tricky bits come in when the commit parents can "change" according to these other features. The commit-graph would need to change at the same time, and this is actually very difficult to get correct.

Show 7 quoted lines

> Here's the idea that may help others on the same path: Some warning
> output when attempting to use commit-graph when it is disabled (either
> by configuration or automatically).
>
> I think others that come across commit-graph may have tried such
> tricks (like shallow clones) to better work with their repositories,
> and it could be frustrating that commit-graph has no apparent effect.

This is a good idea, and I would happily review a patch that added such a warning.

The warning would want to be in builtin/commit-graph.c, and use the commit_graph_compatible() method from commit-graph.c. (You'll need to expose the method in the .h file.)

Thanks!

-Stolee