git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] t/t8006: Demonstrate blame is broken when cachetextconv is on

From
Kirill Smelkov <kirr@landau.phys.spbu.ru>
Date
Dec 18, 2010, 14:54 UTC
Message-ID
<b714f1939ef4fc73cb5f55c1d7784a08a34d3c3d.1292681111.git.kirr@landau.phys.spbu.ru>

I have a git repository with lots of .doc and .pdf files. There diff works ok, but blaming is painfully slow without textconv cache, and with textconv cache, blame says lots of lines are 'Not Yet Committed' which is wrong.

Here is a test that demonstrates the problem.
Cc: Axel Bonnet <axel.bonnet@ensimag.imag.fr>
Cc: Clément Poulain <clement.poulain@ensimag.imag.fr>
Cc: Diane Gasselin <diane.gasselin@ensimag.imag.fr>
Cc: Jeff King <peff@peff.net>
Signed-off-by: Kirill Smelkov <kirr@landau.phys.spbu.ru>
---
 t/t8006-blame-textconv.sh |   22 ++++++++++++++++++++++
 1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/t/t8006-blame-textconv.sh b/t/t8006-blame-textconv.sh
index dbf623b..fe90541 100755
--- a/t/t8006-blame-textconv.sh
+++ b/t/t8006-blame-textconv.sh
@@ -73,6 +73,28 @@ test_expect_success 'blame --textconv going through revisions' '
 	test_cmp expected result
 '
 
+test_expect_success 'setup +cachetextconv' '
+	git config diff.test.cachetextconv true
+'
+
+cat >expected_one <<EOF
+(Number2 2010-01-01 20:00:00 +0000 1) converted: test 1 version 2
+EOF
+
+# one.bin is blamed as 'Not Committed yet'
+test_expect_failure 'blame --textconv works with textconvcache' '
+	git blame --textconv two.bin >blame &&
+	find_blame <blame >result &&
+	test_cmp expected result &&
+	git blame --textconv one.bin >blame &&
+	find_blame  <blame >result &&
+	test_cmp expected_one result
+'
+
+test_expect_success 'setup -cachetextconv' '
+	git config diff.test.cachetextconv false
+'
+
 test_expect_success 'make a new commit' '
 	echo "bin: test number 2 version 3" >>two.bin &&
 	GIT_AUTHOR_NAME=Number3 git commit -a -m Third --date="2010-01-01 22:00:00"
-- 
1.7.3.4.570.g14308
Next: Kirill Smelkov
Message 1 of 13 in “t/t8006: Demonstrate blame is broken when cachetextconv is on”
  1. 1/2 t/t8006: Demonstrate blame is broken when cachetextconv is onKirill Smelkov, Dec 18, 2010
  2. 2/2 fill_textconv(): Don't get/put cache if sha1 is not validKirill Smelkov, Dec 18, 2010
  3. Jeff KingDec 18, 2010
  4. Kirill SmelkovDec 18, 2010
  5. Junio C HamanoDec 19, 2010
  6. Kirill SmelkovDec 19, 2010
  7. Junio C HamanoDec 20, 2010
  8. Jeff KingDec 20, 2010
  9. Kirill SmelkovDec 20, 2010
  10. Junio C HamanoDec 20, 2010
  11. Jeff KingDec 20, 2010
  12. Junio C HamanoDec 20, 2010
  13. Junio C HamanoDec 20, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.