Re: Verbose commit message diff not showing changes from pre-commit hook
On 26/07/20 19:41, René Scharfe wrote:
Show 18 quoted lines
>>
>> However, ec84bd00 moved the place where we re-read the on-disk index
>> in the sequence, and updated a message that used to read:
>>
>> - /*
>> - * Re-read the index as pre-commit hook could have updated it,
>> - * and write it out as a tree.
>> - */
>>
>> to:
>>
>> + /*
>> + * Re-read the index as pre-commit hook could have updated it,
>> + * and write it out as a tree. We must do this before we invoke
>> + * the editor and after we invoke run_status above.
>> + */
> When I read "refactor" in the title, I assume that the patch in
> question doesn't change user-visible behavior.
That was probably the intention.
>> Unfortunately there is no mention of the reason why we "must" here.
> @Paolo: Do you perhaps remember the reason?
I think the idea was to use run_status for the "commitable" assignment.
Paolo
Paolo Bonzini <pbonzini@redhat.com>