git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 02/13] do_for_each_ref(): move docstring to the header file

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Jun 18, 2016, 04:15 UTC
Message-ID
<b509036e91fcdce43a8e42108117a5daa1a499da.1466222921.git.mhagger@alum.mit.edu>
In-Reply-To
<cover.1466222921.git.mhagger@alum.mit.edu>
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 refs/files-backend.c |  9 ---------
 refs/refs-internal.h | 10 +++++++++-
 2 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/refs/files-backend.c b/refs/files-backend.c
index bbf96ad..8fa897b 100644
--- a/refs/files-backend.c
+++ b/refs/files-backend.c
@@ -1878,15 +1878,6 @@ static int do_for_each_entry(struct ref_cache *refs, const char *base,
 	return retval;
 }
 
-/*
- * Call fn for each reference in the specified ref_cache for which the
- * refname begins with base.  If trim is non-zero, then trim that many
- * characters off the beginning of each refname before passing the
- * refname to fn.  flags can be DO_FOR_EACH_INCLUDE_BROKEN to include
- * broken references in the iteration.  If fn ever returns a non-zero
- * value, stop the iteration and return that value; otherwise, return
- * 0.
- */
 int do_for_each_ref(const char *submodule, const char *base,
 		    each_ref_fn fn, int trim, int flags, void *cb_data)
 {
diff --git a/refs/refs-internal.h b/refs/refs-internal.h
index 1bb3d87..b4dd545 100644
--- a/refs/refs-internal.h
+++ b/refs/refs-internal.h
@@ -249,7 +249,15 @@ int rename_ref_available(const char *oldname, const char *newname);
 #define DO_FOR_EACH_INCLUDE_BROKEN 0x01
 
 /*
- * The common backend for the for_each_*ref* functions
+ * Call fn for each reference in the specified submodule for which the
+ * refname begins with base. If trim is non-zero, then trim that many
+ * characters off the beginning of each refname before passing the
+ * refname to fn. flags can be DO_FOR_EACH_INCLUDE_BROKEN to include
+ * broken references in the iteration. If fn ever returns a non-zero
+ * value, stop the iteration and return that value; otherwise, return
+ * 0.
+ *
+ * This is the common backend for the for_each_*ref* functions.
  */
 int do_for_each_ref(const char *submodule, const char *base,
 		    each_ref_fn fn, int trim, int flags, void *cb_data);
-- 
2.8.1
Previous: Michael HaggertyNext: Michael Haggerty
Message 3 of 14 in “Reference iterators”
  1. 00/13 Reference iteratorsMichael Haggerty, Jun 18, 2016
  2. 01/13 refs: remove unnecessary "extern" keywordsMichael Haggerty, Jun 18, 2016
  3. 02/13 do_for_each_ref(): move docstring to the header fileMichael Haggerty, Jun 18, 2016
  4. 04/13 delete_refs(): add a flags argumentMichael Haggerty, Jun 18, 2016
  5. 06/13 get_ref_cache(): only create an instance if there is a submoduleMichael Haggerty, Jun 18, 2016
  6. 07/13 entry_resolves_to_object(): rename function from ref_resolves_to_object()Michael Haggerty, Jun 18, 2016
  7. 08/13 ref_resolves_to_object(): new functionMichael Haggerty, Jun 18, 2016
  8. 05/13 remote rm: handle symbolic refs correctlyMichael Haggerty, Jun 18, 2016
  9. 09/13 refs: introduce an iterator interfaceMichael Haggerty, Jun 18, 2016
  10. 10/13 do_for_each_ref(): reimplement using reference iterationMichael Haggerty, Jun 18, 2016
  11. 13/13 for_each_reflog(): reimplement using iteratorsMichael Haggerty, Jun 18, 2016
  12. 03/13 refs: use name "prefix" consistentlyMichael Haggerty, Jun 18, 2016
  13. 11/13 for_each_reflog(): don't abort for bad referencesMichael Haggerty, Jun 18, 2016
  14. 12/13 dir_iterator: new API for iterating over a directory treeMichael Haggerty, Jun 18, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.