Re: [PATCH v3 0/9] More index cleanups
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Jan 23, 2021, 21:05 UTC
- Message-ID
- <b4a4df78-fb36-5a27-7ec0-79d752de73ae@gmail.com>
- In-Reply-To
- <CABPp-BHFiXLOS4Vbm156+JxZw=t2P_Fzf8E3p4u0iwCv28_Rdw@mail.gmail.com>
On 1/23/2021 3:29 PM, Elijah Newren wrote:
> On Sat, Jan 23, 2021 at 11:58 AM Derrick Stolee via GitGitGadget > <gitgitgadget@gmail.com> wrote: >> >> This is based on ds/cache-tree-basics.
...
Show 21 quoted lines
>> -+ grep -e "\"region_enter\".*\"category\":\"$1\",\"label\":\"$2\"" "$3" >> ++ grep -e '"region_enter".*"category":"'"$1"'","label":"'"$2"\" "$3" >> + exitcode=$? >> + >> -+ if test $exitcode != $expect_exit >> ++ if test $exitcode != $expect_exit = 1] > > I don't understand this change. Is it even valid code? What does it mean? > >> + then >> + return 1 >> + fi >> + >> -+ grep -e "\"region_leave\".*\"category\":\"$1\",\"label\":\"$2\"" "$3" >> ++ grep -e '"region_leave".*"category":"'"$1"'","label":"'"$2"\" "$3" >> + exitcode=$? >> + >> -+ if test $exitcode != $expect_exit >> ++ if test $exitcode != $expect_exit = 1] > > Same comment
Wow. I am sorry this snuck in. It's an artifact of what I was trying [1] in response to Junio's comments, but then did not completely undo. I'm surprised this ran without error. Will fix.
[1] https://lore.kernel.org/git/8406512b-3d9f-e899-24fd-8a09c4af3569@gmail.com/