git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] maintenance: test commit-graph auto condition

From
Derrick Stolee <stolee@gmail.com>
Date
Oct 8, 2020, 00:13 UTC
Message-ID
<b4918483-5ce6-b002-77dc-92d3049f2069@gmail.com>
In-Reply-To
<xmqqblhd23dc.fsf@gitster.c.googlers.com>
On 10/7/2020 4:22 PM, Junio C Hamano wrote:
Show 5 quoted lines
> Hmph.  Something in ds/maintenance-part-2 series does not seem to
> work well with this change.  I noticed it when testing today's first
> integration cycle of jch and seen branches, but even when applied to
> ds/maintenance-part-2 alone without any other topics in seen, it
> seems to break in an unexpected place.

Thank you for alerting me to this. I should have ran the tests after merging with the other branches in progress.

It seems my issue is that I use "test_commit one" in two places now, so the second complains that nothing is new to commit.

The simplest fix is to use "first", "second", and "third" in this patch, so I'll send a v2 soon with that change.

Thanks, -Stolee

Previous: Junio C HamanoNext: Derrick Stolee via GitGitGadget
Message 3 of 4 in “maintenance: test commit-graph auto condition”
  1. maintenance: test commit-graph auto conditionDerrick Stolee via GitGitGadget, Oct 7, 2020
  2. Junio C HamanoOct 7, 2020
  3. Derrick StoleeOct 8, 2020
  4. maintenance: test commit-graph auto conditionDerrick Stolee via GitGitGadget, Oct 8, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.