git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 17/29] tests: t3440: create expect files at point of use

From
KHKristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date
Oct 15, 2025, 14:02 UTC
Message-ID
<b4331d08-5105-4788-880e-af710cdcdd59@app.fastmail.com>
In-Reply-To
<199e82ac06b.22809060320824.5985600477588171363@linux.beauty>
On Wed, Oct 15, 2025, at 15:58, Li Chen wrote:
Show 15 quoted lines
>[snip]
>  > (if that’s what you are doing).  It is to recreate them as if the
> series
>  > was perfectly written to begin with; if one patch introduces
>  > `--trailers` and a test file, then there should be no need with
>  > follow-up patches that improve the test file style, refactors it, and
>  > so on.
>
> Thanks for the tip. I split the changes into separate commits to ease
> review,
>  as Phillip suggested in
> https://lore.kernel.org/git/d4c9f082-52be-48d9-b817-fcb8a72e1bd7@gmail.com/.
>
> It seems I may have overdone it? If so, I'll try for a better balance
> in the next version.

Thank you. It seems like I should have skimmed the previous rounds more carefully. :)

Cheers
Previous: Li ChenNext: Phillip Wood
Message 26 of 43 in “rebase: support --trailer”
  1. 00/29 rebase: support --trailerLi Chen, Oct 14, 2025
  2. 01/29 trailer: append trailers in-process and drop the fork to `interpret-trailers`Li Chen, Oct 14, 2025
  3. Kristoffer HaugsbakkOct 14, 2025
  4. Li ChenOct 21, 2025
  5. 02/29 trailer: restore interpret_trailers helperLi Chen, Oct 14, 2025
  6. 03/29 trailer: drop --trailer prefix handling in amend helperLi Chen, Oct 14, 2025
  7. 04/29 trailer: move config_head and arg_head to if storageLi Chen, Oct 14, 2025
  8. 05/29 trailer: use bool for had_trailer_beforeLi Chen, Oct 14, 2025
  9. 06/29 interpret-trailers: buffer stdout outputLi Chen, Oct 14, 2025
  10. 07/29 trailer: mirror interpret-trailers output flowLi Chen, Oct 14, 2025
  11. 08/29 trailer: handle trailer append failures gentlyLi Chen, Oct 14, 2025
  12. 09/29 rebase: support --trailerLi Chen, Oct 14, 2025
  13. Kristoffer HaugsbakkOct 14, 2025
  14. Li ChenOct 22, 2025
  15. 10/29 rebase: inline trailer state pathsLi Chen, Oct 14, 2025
  16. 11/29 rebase: reuse buffer for trailer argsLi Chen, Oct 14, 2025
  17. 12/29 rebase: drop redundant strbuf_release callLi Chen, Oct 14, 2025
  18. 13/29 rebase: skip stripping of --trailer option prefixLi Chen, Oct 14, 2025
  19. 14/29 rebase: die on invalid trailer argsLi Chen, Oct 14, 2025
  20. 15/29 rebase: validate trailers with configured separatorsLi Chen, Oct 14, 2025
  21. 16/29 sequencer: add trailers to message before writing fileLi Chen, Oct 14, 2025
  22. Kristoffer HaugsbakkOct 14, 2025
  23. 17/29 tests: t3440: create expect files at point of useLi Chen, Oct 14, 2025
  24. Kristoffer HaugsbakkOct 14, 2025
  25. Li ChenOct 15, 2025
  26. Kristoffer HaugsbakkOct 15, 2025
  27. Phillip WoodOct 23, 2025
  28. Li ChenOct 28, 2025
  29. Phillip WoodNov 3, 2025
  30. 18/29 tests: t3440: check apply backend error includes optionLi Chen, Oct 14, 2025
  31. 19/29 tests: t3440: use test_commit_message for trailer checksLi Chen, Oct 14, 2025
  32. 20/29 tests: t3440: drop redundant resets and pass branch to rebase where neededLi Chen, Oct 14, 2025
  33. 21/29 tests: t3440: assert trailer on HEAD after conflict rebaseLi Chen, Oct 14, 2025
  34. 22/29 rebase: persist --trailer options across restartsLi Chen, Oct 14, 2025
  35. 23/29 tests: t3440: remove redundant --keep-emptyLi Chen, Oct 14, 2025
  36. 24/29 tests: t3440: use helper for trailer checksLi Chen, Oct 14, 2025
  37. 25/29 tests: t3440: test --trailer without valuesLi Chen, Oct 14, 2025
  38. Kristoffer HaugsbakkOct 14, 2025
  39. 26/29 tests: t3440: convert ex.com to example.comLi Chen, Oct 14, 2025
  40. 27/29 tests: t3440: ensure trailers persist after rebase continueLi Chen, Oct 14, 2025
  41. 28/29 tests: t3440: exercise trailer config mappingLi Chen, Oct 14, 2025
  42. 29/29 sequencer: honor --trailer with fixup -CLi Chen, Oct 14, 2025
  43. Li ChenOct 14, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.