Re: [PATCH v4 17/29] tests: t3440: create expect files at point of use
- From
- Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
- Date
- Oct 15, 2025, 14:02 UTC
- Message-ID
- <b4331d08-5105-4788-880e-af710cdcdd59@app.fastmail.com>
- In-Reply-To
- <199e82ac06b.22809060320824.5985600477588171363@linux.beauty>
On Wed, Oct 15, 2025, at 15:58, Li Chen wrote:
Show 15 quoted lines
>[snip] > > (if that’s what you are doing). It is to recreate them as if the > series > > was perfectly written to begin with; if one patch introduces > > `--trailers` and a test file, then there should be no need with > > follow-up patches that improve the test file style, refactors it, and > > so on. > > Thanks for the tip. I split the changes into separate commits to ease > review, > as Phillip suggested in > https://lore.kernel.org/git/d4c9f082-52be-48d9-b817-fcb8a72e1bd7@gmail.com/. > > It seems I may have overdone it? If so, I'll try for a better balance > in the next version.
Thank you. It seems like I should have skimmed the previous rounds more carefully. :)
Cheers