Re: [RFC/PATCH] packfile: use extra variable to clarify code in use_pack()

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Mar 12, 2019, 17:39 UTC
Message-ID: <b4106d4b-5f9e-4577-c8ed-641df33d4fb5@ramsayjones.plus.com>
In-Reply-To: <e561b83f-cf1c-eef8-7651-8519ce105491@ramsayjones.plus.com>

On 12/03/2019 16:55, Ramsay Jones wrote:

Show 19 quoted lines

> From: Jeff King <peff@peff.net>
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Jeff,
> 
> I recently tried (yet again) to tidy up some old branches. When I get
> around to doing a 'git gc; git fsck' I always take a quick look at
> the 'dangling' commits, just before a 'git gc --prune=now'.
> 
> I had no recollection of this commit, from last October, but a quick
> look at the ML archive found this [1] discussion. I obviously thought
> it was worth saving this thought of yours. ;-) So, having deleted this
> already, I did a quick 'format-patch' to see if anyone thinks it is
> worth applying.
> 
> [1] https://public-inbox.org/git/20181013024624.GB15595@sigill.intra.peff.net/#t
>

Heh, of course I should have tried applying on top of today's codebase before sending it out! :(

Having just done so, it quickly showed that this patch assumes that the 'left' parameter to use_pack() has been changed from an 'unsigned long *' to an 'size_t *' as part of the series that was being discussed in the above link.

Ah, well, sorry for the noise!

ATB, Ramsay Jones