Re: [RFC PATCH] bisect: Honor log.date

From: Peter Krefting <peter@softwolves.pp.se>
Date: Mar 28, 2024, 23:18 UTC
Message-ID: <b3f7c1c7f126a3c0a65f034ed6166d6a@softwolves.pp.se>
In-Reply-To: <CAPig+cSKbGW57dh13T6p20B_EY_C4K=LiQ3TP59wheMSi4qsQA@mail.gmail.com>

2024-03-28 22:38 skrev Eric Sunshine:

Show 5 quoted lines

> Nit: The comment doesn't tell the reader anything that the code itself
> isn't already clearly telling the reader, thus the comment is
> redundant and unnecessary. Moreover, the comment is likely to become
> outdated when people adjust the code but forget to update the comment.
> As such, I'd recommend dropping the comment altogether.

Yes, that does make sense. I copied the code for invoking "git show" from builtin/notes.c, which does have that type of redundant comment.

I'll remove it.

-- 
\\// Peter - http://www.softwolves.pp.se/