git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] patience diff: remove unused variable

From
PGPhillip Wood via GitGitGadget <gitgitgadget@gmail.com>
Date
May 4, 2021, 09:25 UTC
Message-ID
<b38a4e02d4f1c8e77bbc8ed1e4e8507d41ab9fd8.1620120345.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.948.git.1620120345.gitgitgadget@gmail.com>
From: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
---
 xdiff/xpatience.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/xdiff/xpatience.c b/xdiff/xpatience.c
index db2d53e89cb0..c5d48e80aefb 100644
--- a/xdiff/xpatience.c
+++ b/xdiff/xpatience.c
@@ -284,9 +284,6 @@ static int walk_common_sequence(struct hashmap *map, struct entry *first,
 
 		/* Recurse */
 		if (next1 > line1 || next2 > line2) {
-			struct hashmap submap;
-
-			memset(&submap, 0, sizeof(submap));
 			if (patience_diff(map->file1, map->file2,
 					map->xpp, map->env,
 					line1, next1 - line1,
-- 
gitgitgadget
Previous: Junio C Hamano
Message 8 of 8 in “A couple of small patience diff cleanups”
  1. 0/2 A couple of small patience diff cleanupsPhillip Wood via GitGitGadget, May 4, 2021
  2. 1/2 patience diff: remove unnecessary string comparisonsPhillip Wood via GitGitGadget, May 4, 2021
  3. Junio C HamanoMay 5, 2021
  4. Phillip WoodMay 5, 2021
  5. Johannes SchindelinMay 5, 2021
  6. Phillip WoodMay 5, 2021
  7. Junio C HamanoMay 6, 2021
  8. 2/2 patience diff: remove unused variablePhillip Wood via GitGitGadget, May 4, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.