Re: [PATCH 4/4] ALLOC_GROW: avoid -Wsign-compare warnings
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- Sep 22, 2017, 15:36 UTC
- Message-ID
- <b3846c1f-0335-8afa-c155-c2726f57679c@ramsayjones.plus.com>
- In-Reply-To
- <xmqqd16jl5yb.fsf@gitster.mtv.corp.google.com>
On 22/09/17 05:20, Junio C Hamano wrote:
Show 15 quoted lines
>> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
>> index a57b4f058..a6ee653bf 100644
>> --- a/builtin/pack-objects.c
>> +++ b/builtin/pack-objects.c
>> @@ -2563,8 +2563,8 @@ struct in_pack_object {
>> };
>>
>> struct in_pack {
>> - int alloc;
>> - int nr;
>> + unsigned int alloc;
>> + unsigned int nr;
>
> This is a bit questionable ;-) but it is something I can locally
> tweak easily.Heh, it took me a minute to see what you were referring to! ;-) Yep, sorry, I don't know how I managed to add the extra space. (I don't think I can blame vim - PEBKAC).
ATB, Ramsay Jones