Re: [PATCH v2] archive: rewrite description for compression level option

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Oct 16, 2021, 05:19 UTC
Message-ID: <b28a55da-c74b-8061-108f-10f9df2c0d6f@gmail.com>
In-Reply-To: <xmqq7dee8c5v.fsf@gitster.g>

On 15/10/21 23.50, Junio C Hamano wrote:

Show 13 quoted lines

> I do not think it is a good idea to remove the backend-specific
> option section like this patch does, as the next archiver may not
> even support `-<digit>`.  Even with the existing two backends, the
> description of it need to be different (cf. the other response I
> sent you last night on "--fast/--best"?).  Rather, the first thing
> to improve would be to _add_ a section for `tar` format, next to the
> `zip` format, I would think, as those who wants to write `tar` do
> not have to read `zip` specific options, and vice versa.
> 
> The new paragraph on `-#` in the patch may work as a replacement for
> existing explanation for `zip`-specific extra options, but it needs
> to drop the changes made to make it applicable to any format, like
> "depending on ... backend" and "(zip only)" if we want to take it.

In current situation, both zip and tar backend supports the compression level option, so it will end up duplicating description of the option for both backends (with slight differences).

-- 
An old man doll... just what I always wanted! - Clara