Re: [PATCH 0/2] extra cleanups on top of ds/branch-checked-out

From: Derrick Stolee <derrickstolee@github.com>
Date: Jun 19, 2022, 18:12 UTC
Message-ID: <b23d209f-80bf-c741-dc47-68af48fa3220@github.com>
In-Reply-To: <Yq6deQf96g8M5wdg@coredump.intra.peff.net>

On 6/18/2022 11:52 PM, Jeff King wrote:

Show 12 quoted lines

> Here are a few extra cleanups on top of ds/branch-checked-out; that
> topic made some local "worktrees" variables obsolete, but didn't get rid
> of them.
> 
> The first was detected by my local -Wunused-parameter topic. The second
> is a similar case that the compiler doesn't happen to notice, but which
> I went digging for after seeing the first. I think that should be the
> extent of it. There's a third caller in validate_new_branchname(), but
> the series already got rid of its worktrees variable.
> 
>   [1/2]: fetch: stop passing around unused worktrees variable
>   [2/2]: branch: drop unused worktrees variable

Good catch. Thanks for identifying these. You are right that it would be nice if a compiler could identify these "create and free, no use" situations.

Thanks, -Stolee