git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] commit-graph.txt: improve formatting for asciidoc

From
Derrick Stolee <stolee@gmail.com>
Date
Aug 22, 2018, 01:19 UTC
Message-ID
<b21df6d2-19a4-766f-fea0-778c92785410@gmail.com>
In-Reply-To
<xmqqtvnn76i4.fsf@gitster-ct.c.googlers.com>
On 8/21/2018 5:29 PM, Junio C Hamano wrote:
Show 31 quoted lines
> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Derrick Stolee <dstolee@microsoft.com>
>>
>> When viewing commit-graph.txt as a plain-text document, it makes
>> sense to keep paragraphs left-padded between bullet points.
>> However, asciidoc converts these left-padded paragraphs as monospace
>> fonts, creating an unpleasant document. Remove the padding.
> That's completely backwards.
>
> These indented two paragraphs that follow "... the following
> property:" do not fall into the same classes of paragraphs as
> others.  The way the text version makes them stand out by indenting
> clearly show these two are what "... the following ..." refers to.
>
> Perhaps these two would want to become a bulleted list or
> something.
>
>> The "Future Work" section includes a bulleted list of items, and one
>> item has sub-items. These do not render properly in asciidoc, so
>> remove the sub-list and incorporate them into the paragraph.
>>
>> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
>> ---
>>   Documentation/technical/commit-graph.txt | 43 +++++++++++-------------
> I said I didn't check if commit-graph-format.txt doc format
> correctly, but that does not mean you do not have to ;-).  I suspect
> that most of the contents would become monospaced wall of text,
> which is no better than the original text and because only the
> headings are typeset in different font, the result actually would be
> harder to read than the original.

I compared the results of commit-graph-format.txt to pack-format.txt. Since I had based the format of commit-graph-format.txt on that file, the output was remarkably similar (and hence I couldn't find anything to change).

Show 8 quoted lines
> We are not in a hurry to do this during the pre-release period, are
> we?  My understanding is that the original text documentation files
> will be shipped and installed, and they are adequately readable
> (correct me if it is not the case).
>
> Unless we are making the result a lot more readable as the original
> text, let's not distract ourselves by rerolling this in too quick
> cycles without giving us sufficiently big improvements.

No rush! I'll wait until the release calms down for a v3, and read the helpful docs on asciidoc format that Eric shared earlier.

Thanks, -Stolee

Previous: Junio C Hamano
Message 9 of 9 in “Docs: Add commit-graph tech docs to Makefile”
  1. 0/1 Docs: Add commit-graph tech docs to MakefileDerrick Stolee via GitGitGadget, Aug 21, 2018
  2. 1/1 Docs: Add commit-graph tech docs to MakefileDerrick Stolee via GitGitGadget, Aug 21, 2018
  3. Junio C HamanoAug 21, 2018
  4. 0/2 Docs: Add commit-graph tech docs to MakefileDerrick Stolee via GitGitGadget, Aug 21, 2018
  5. 1/2 Docs: Add commit-graph tech docs to MakefileDerrick Stolee via GitGitGadget, Aug 21, 2018
  6. 2/2 commit-graph.txt: improve formatting for asciidocDerrick Stolee via GitGitGadget, Aug 21, 2018
  7. Eric SunshineAug 21, 2018
  8. Junio C HamanoAug 21, 2018
  9. Derrick StoleeAug 22, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.