Re: [PATCH 07/34] doc SYNOPSIS & -h: fix incorrect alternates syntax

From: Victoria Dye <vdye@github.com>
Date: Sep 19, 2022, 22:09 UTC
Message-ID: <b1c44436-92d1-067c-fb0a-be4049f3031b@github.com>
In-Reply-To: <patch-07.34-a070c97f29b-20220902T092734Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:

Show 5 quoted lines

> Fix the incorrect "[-o | --option <argument>]" syntax, which should be
> "[(-o | --option) <argument>]", we were previously claiming that only
> the long option accepted the "<argument>", which isn't what we meant.
> 
> Unlike a preceding commit where this was fixed for commands which had

nit: if you're referring to patch 10 [1], it wouldn't be a "preceding" commit. Otherwise, I'm not sure which commit you're referring to?

In any case, I'd personally prefer that this patch is combined with patch 10 anyway, since both fix the same underlying issue (just in different places). Neither patch is particularly large, and it would be nice to make (and review!) all of the "fix alternates syntax" changes at once.

[1] https://lore.kernel.org/git/patch-10.34-965f6b3b3cb-20220902T092734Z-avarab@gmail.com/

Show 5 quoted lines

> inconsistent "-h" and *.txt, for "stash" it's been with us in both the
> "-h" and *.txt since bd514cada4b (stash: introduce 'git stash store',
> 2013-06-15).
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>