Re: [PATCH v3 2/8] t6036, t6042: testcases for rename collision of already conflicting files

From: Derrick Stolee <stolee@gmail.com>
Date: Oct 31, 2018, 14:01 UTC
Message-ID: <b14a0c79-5dce-a1dd-cd26-16e061154c43@gmail.com>
In-Reply-To: <20181019193111.12051-3-newren@gmail.com>

On 10/19/2018 3:31 PM, Elijah Newren wrote:

> +test_expect_success "setup nested conflicts" '

nit: should these test names be single-quoted? I see you using double-quotes in PATCH 1/8 as well, but that seems to be because there are variables in the test names.

...

> +test_expect_failure "check nested conflicts" '

Same here.

> +test_expect_success "setup nested conflicts from rename/rename(2to1)" '

> +test_expect_failure "check nested conflicts from rename/rename(2to1)" '

Thanks, -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.