git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] environment: move ignore_case into repo_config_values

From
Tian Yuchen <cat@malon.dev>
Date
Jun 19, 2026, 16:01 UTC
Message-ID
<b0ad1eba-a4e2-418b-816f-5861b029cf23@malon.dev>
In-Reply-To
<xmqqldcct2hx.fsf@gitster.g>
On 6/18/26 21:14, Junio C Hamano wrote:
Show 16 quoted lines
> Tian Yuchen <cat@malon.dev> writes:
> 
>> Related materials:
>>
>>   [1] In this patch to migrate protect_hfs and protect_ntfs, the approach
>> of introducing getters has been endorsed.
>>
>>   [2] Derrick Stolee's previous attempt. The reasons for the failure are
>> also mentioned in [1].
> 
> [1] here refers to the starting message of the whole hfs/ntfs thing.
> Do you mean that people must read the entire thread to find out what
> the reasons for the failure was?  For that matter, it is not clear,
> unless readers read the whole thread, where the approach of using
> getters was "endorsed", either.
>

What I meant to say was that the reasons were already mentioned in the _cover-letter_ for the patch which the link refers to. It’s certainly my fault for not expressing myself clearly. Nevertheless, I’ve briefly explained the content of the link directly in the cover-letter for V3.

Show 15 quoted lines
>> [1] https://lore.kernel.org/git/20260606143412.15443-1-cat@malon.dev/
>> [2] https://lore.kernel.org/git/2b4198c09cb6c04c60608d19072d419503dfe5df.1685716421.git.gitgitgadget@gmail.com/
> 
>> Changes since V1:
>>
>>   - s/repo_get_ignore_case()/repo_ignore_case()
>>
>>   - Use repo->initialized instead of repo->gitdir
> 
> I do not think I have any objections to these changes from the
> previous iteration.  There may be some other things in the new
> iteration but I'll have to go in and read the patches to find them
> out (if they exist).
> 
> Thanks.

Additionally, I’ll change 'repo->gitdir' to using 'repo->initialized' for the previous three bits as well.

Regards, yuchen
Previous: Junio C HamanoNext: Tian Yuchen
Message 10 of 18 in “environment: move ignore_case into repo_config_values”
  1. 0/2 environment: move ignore_case into repo_config_valuesTian Yuchen, Jun 17, 2026
  2. 1/2 environment: move ignore_case into repo_config_valuesTian Yuchen, Jun 17, 2026
  3. Junio C HamanoJun 17, 2026
  4. Tian YuchenJun 18, 2026
  5. 2/2 config: use repo_get_ignore_case() to access core.ignorecaseTian Yuchen, Jun 17, 2026
  6. 0/2 environment: move ignore_case into repo_config_valuesTian Yuchen, Jun 18, 2026
  7. 1/2 environment: move ignore_case into repo_config_valuesTian Yuchen, Jun 18, 2026
  8. 2/2 config: use repo_ignore_case() to access core.ignorecaseTian Yuchen, Jun 18, 2026
  9. Junio C HamanoJun 18, 2026
  10. Tian YuchenJun 19, 2026
  11. 0/2 environment: move ignore_case into repo_config_valuesTian Yuchen, Jun 19, 2026
  12. 1/2 environment: move ignore_case into repo_config_valuesTian Yuchen, Jun 19, 2026
  13. 2/2 config: use repo_ignore_case() to access core.ignorecaseTian Yuchen, Jun 19, 2026
  14. Junio C HamanoJun 21, 2026
  15. Tian YuchenJun 22, 2026
  16. Junio C HamanoJun 22, 2026
  17. Johannes SchindelinJul 10, 2026
  18. Junio C HamanoJul 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.