Re: [PATCH RFC] git-send-email --expand-aliases

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Nov 24, 2009, 10:43 UTC
Message-ID: <b0943d9e0911240243m13730f0bw34f2f18cf41f9079@mail.gmail.com>
In-Reply-To: <b8197bcb0911232312l251dfbc9va671388cfb7fe57b@mail.gmail.com>

2009/11/24 Karl Wiberg <kha@treskal.com>:

Show 32 quoted lines

> On Tue, Nov 24, 2009 at 1:45 AM, Alex Chiang <achiang@hp.com> wrote:
>
>> * Junio C Hamano <gitster@pobox.com>:
>>
>> > If you are changing StGit to call git-send-email anyway, why not
>> > arrange stgit to call git-send-email to send the message out
>> > instead, instead of sending messages on its own?
>>
>> Yeah, I thought about that as I was poking around further in StGit
>> to figure out how it would be calling git-send-email. ;)
>>
>> > I imagine the internal implementation of stg mail would work
>> > something like:
>> >
>> >     prepare messages to send out
>> >     call git-send-email and have it send them
>> >
>> > What am I missing?
>>
>> My lack of familiarity with StGit internals. ;)
>>
>> Your suggestion is much better. I'll take a closer look at StGit and
>> see how feasible it is.
>>
>> Unless Catalin has strong objections?
>
> I think that sounds like a splendid idea. It would be interesting to
> see just how thin a wrapper around git send-email (and format-patch)
> stg mail could become, without sacrificing features anyone actually
> uses. The main complication could be stg mail's templates.
>
> Catalin, how wedded are you to those? ;-)

Historically, I think "stg mail" was implemented before git-send-email existed. It was also a good way to check who's using stgit for sending patches :-) (the message-id).

I use templates to send patches to the ARM Linux gatekeeper via a patch management system which only accepts patches formatted in a certain way (things improved a bit recently and the format was relaxed). But I find myself mostly sending pull requests these days, so that's not a critical feature for me.

If there are no other users of the stg mail templates, I'm happy to let them go. Otherwise, we can replace the sendmail with git-send-email in stgit.

It seems that git-format-patch and git-send-email have all the features stgit has. We would need to keep some of the interactive options like --edit-cover and --edit-patches since we use git-format-patch and git-send-email in one go.

-- 
Catalin