Re: [StGit PATCH 5/5] Convert "float" to the lib infrastructure

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Mar 16, 2009, 16:36 UTC
Message-ID: <b0943d9e0903160936m1971fbaft928a495eaab4fa20@mail.gmail.com>
In-Reply-To: <20090313024137.GE15393@diana.vm.bytemark.co.uk>

2009/3/13 Karl Hasselström <kha@treskal.com>:

Show 16 quoted lines

> On 2009-03-12 12:09:18 +0000, Catalin Marinas wrote:
>>  options = [
>>      opt('-s', '--series', action = 'store_true',
>> -        short = 'Rearrange according to a series file')]
>> +        short = 'Rearrange according to a series file')
>> +    ] + argparse.keep_option()
>
> This flag should take the filename as a parameter, both because it's
> the right thing to do and because it'll make the tab completion work
> right (as is, it'll complete on patch names after the -s flag).
>
> Something like
>
>  opt('-s', '--series', type = 'string')
>
> ought to do it.

This command was accepting series via the stdin as well (maybe for easier use in other scripts or from stgit.el). Anyway, it doesn't seem to make any difference with the bash completion. It still tries to complete patches but when this fails bash lists files if the prefix matches some.

-- 
Catalin