Re: [StGit PATCH] Check for local changes with "goto"

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Jan 15, 2009, 22:24 UTC
Message-ID: <b0943d9e0901151424m49f6869cq1255cf841703dc9d@mail.gmail.com>
In-Reply-To: <20090115083700.GB24890@diana.vm.bytemark.co.uk>

2009/1/15 Karl Hasselström <kha@treskal.com>:

> I'm not opposed to the change as such (even if I personally think it's
> very convenient to allow operations like goto if the local changes
> don't touch the same files), but ...

That would work if "refresh" only commits files previously added to the patch (the same way as quilt). I found myself many times moving to another patch and refreshing more than I wanted to add to that patch because I forgot to run "status" before "goto".

Maybe we can make this configurable to accommodate both variants (would be even easier if I move the check to transaction.py).

Show 7 quoted lines

> On 2009-01-14 22:59:45 +0000, Catalin Marinas wrote:
>
>>  stgit/commands/common.py  |    7 +++++++
>>  stgit/commands/goto.py    |    8 +++++++-
>
> ... are you sure it wouldn't be better to build the check into
> transaction.py, so that all new-infrastructure command would share it?

OK, I'll do this and repost.

-- 
Catalin