Re: [StGit PATCH] Autosign newly created patches

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Sep 14, 2008, 21:05 UTC
Message-ID: <b0943d9e0809141405u6e309f11q80edcfd59eb942dd@mail.gmail.com>
In-Reply-To: <20080914083728.GB30664@diana.vm.bytemark.co.uk>

2008/9/14 Karl Hasselström <kha@treskal.com>:

Show 7 quoted lines

> On 2008-09-12 22:55:56 +0100, Catalin Marinas wrote:
>
>> This patch adds the autosign configuration variable which is checked
>> by the "new" command to automatically sign the patch message.
>
> Sounds useful. I have a sign-off command in my .emacs, but I expect
> this would be useful for those who don't.

I use emacs for writing code but not that much for stgit commands (I prefer the shell).

Show 6 quoted lines

>> BTW, what happened to the patchdescr.tmpl file? It doesn't seem to
>> be used anymore, however one can save a template file
>
> I don't know. I don't use it myself, so it's perfectly possible that
> I've broken it without noticing, seeing as there is no test suite
> coverage ...

There isn't a test but the command description suggests that patchdesr.tmpl file will be used if present.

Should we keep this feature? The only case where I was using it was for automatic signed-off-by line.

-- 
Catalin