Re: [StGit PATCH] Read several objects at once with git cat-file --batch
- From
- Catalin Marinas <catalin.marinas@gmail.com>
- Date
- Aug 10, 2008, 22:25 UTC
- Message-ID
- <b0943d9e0808101525w1e6f1e60h162a4b137d6dca6c@mail.gmail.com>
- In-Reply-To
- <20080808080614.23424.28169.stgit@yoghurt>
2008/8/8 Karl Hasselström <kha@treskal.com>:
> Instead of spawning a separate cat-file process for every blob and > commit we want to read. This speeds things up slightly: about 6-8% > when uncommitting and rebasing 1470 linux-kernel patches (perftest.py > rebase-newrebase-add-file-linux).
Which version of Git got the --batch option to git-cat-file? It might be possible that default Git in Debian (testing) or Ubuntu doesn't have this option. Maybe we could still have the original behaviour as a fallback.
Otherwise, the patch looks allright. It took me a bit of time to see why we need the new run_background() function (but in my current Git, 1.5.3.4.206.g58ba4, there wasn't such an option; I had to upgrade).
Thanks.
-- Catalin