Re: [StGit PATCH] Fixed default install location

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Jul 27, 2008, 08:21 UTC
Message-ID: <b0943d9e0807270121x43b0a454g1042c0cfe650f2c1@mail.gmail.com>
In-Reply-To: <20080727162750.25b7cdf3@whitehouse.id.au>

2008/7/27 Daniel White <daniel@whitehouse.id.au>:

Show 6 quoted lines

> "Catalin Marinas" <catalin.marinas@gmail.com> wrote:
>>
>> I also use "python setup.py bdist_rpm" when releasing, I think it will
>> get confused by a different prefix.
>
> Not being familiar with distutils, I didn't even see that use case.

I use "python setup.py bdist_rpm", though passing --prefix would probably fix it.

Show 6 quoted lines

> Regardless, the instructions are incorrect and the behaviour surprising.
> When I installed this in a cygwin environment, it went on to clobber
> my system directories.
>
> Would it be more useful to have the Makefile handle the general case and
> setup.py for more specialised cases, such as generating an rpm?

I agree.

> I've thrown some patches together that does some of this.  I can tidy
> these up and put them in a public repository if this sounds like a
> reasonable plan of attack.

Yes, it is. Please base them on my (or Karl's) latest git tree as I already merged this patch.

Thanks.

-- 
Catalin