Re: [StGit PATCH 1/2] Convert "stg refresh" to the new infrastructure

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Jun 29, 2008, 11:07 UTC
Message-ID: <b0943d9e0806290407h5eecd27bg510dd09e0188abca@mail.gmail.com>
In-Reply-To: <20080629102147.GA5098@diana.vm.bytemark.co.uk>

2008/6/29 Karl Hasselström <kha@treskal.com>:

Show 18 quoted lines

> On 2008-06-29 10:42:32 +0100, Catalin Marinas wrote:
>
>> 2008/6/25 Karl Hasselström <kha@treskal.com>:
>>
>> > And in the process, make it more powerful: it will now first
>> > create a temp patch containing the updates, and then try to merge
>> > it into the patch to be updated. If that patch is applied, this is
>> > done by popping, pushing, and coalescing; if it is unapplied, it
>> > is done with an in-index merge.
>>
>> Does it make sense to refresh an unapplied patch? Maybe adding a new
>> file to the patch but I don't really see a need for this.
>
> A change in a different part of the same file should work as well, I
> believe.
>
> But no, I don't have a strong sense that this is super useful. It was
> just easy to allow, so I allowed it.

It seems harmless, unless someone finds some unusual behaviour. What is the conflict behaviour? Is the refresh aborted? For unapplied patches, it is more complicated to let the user solve the conflict.

-- 
Catalin