Re: [StGit PATCH 2/2] Write to a stack log when stack is modified
- From
- Catalin Marinas <catalin.marinas@gmail.com>
- Date
- Feb 20, 2008, 22:46 UTC
- Message-ID
- <b0943d9e0802201446g2840c3d9v576f840936253525@mail.gmail.com>
- In-Reply-To
- <20080214012912.22365.83207.stgit@yoghurt>
On 14/02/2008, Karl Hasselström <kha@treskal.com> wrote:
> Create a log branch (called <branchname>.stgit) for each StGit branch, > and write to it whenever the stack is modified.
The abstractions are really nice (and I still wonder how StGIT codebase increased that much when all I needed two years ago was a simple script-like application to reorder commits :-)).
Anyway, I don't really like the idea of an additional commit (I don't even like the old patch log implementation) when the stack is modified. It needs some profiling but it has a visible impact on stacks with a big number of patches (my last kernel release at www.linux-arm.org/git had 80 patches and it takes a lot of time to push them).
Can we not use some of the automatic reflog recording that GIT does instead of writing a commit? It's cheaper to write a text file than generating a commit. In my kernel repository I have several branches with many patches and, even after "git gc" and repacking, it is still slow (mainly because of git-read-tree but I'd like to reduce the number of calls to GIT).
-- Catalin