Re: [StGit RFC] Make "stg branch -l" faster by getting all git config information in one call

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Dec 13, 2007, 15:38 UTC
Message-ID: <b0943d9e0712130738s18ad303fu17a8412097377900@mail.gmail.com>
In-Reply-To: <87lk7yr7ib.fsf@lysator.liu.se>

On 13/12/2007, David Kågedal <davidk@lysator.liu.se> wrote:

Show 16 quoted lines

> "Catalin Marinas" <catalin.marinas@gmail.com> writes:
>
> > On 13/12/2007, David Kågedal <davidk@lysator.liu.se> wrote:
> >> I have a fair amount of branches, and I noticed that "stg branch -l"
> >> takes ridiculously long to finish.
> >
> > I have the same problem.
> >
> >> Maybe someone can help me find a quicker replacement for the
> >> get_protected call?
>
> Hey, why not put the "protected" flag in the config? Then we can get
> it the same way as the other stuff.
>
> Protecting a branch is a configuration action, so it makes sense to
> put it in the config.

Yes, I'm OK with this. The only problem I see is that we have to change the stgit.formatversion and provide an upgrade in the Series object. However, 'stg branch -l' no longer initialises the Series objects and the upgrade won't happen.

The branch command would have to check format version and force the upgrade if it isn't the required one.

BTW, have you run stg-prof to check where it spends most of the time? Is it caused by Python object creation or GIT calls invoked during the Series objects initialisation. If the latter, we can turn some variables into properties and access them lazily.

-- 
Catalin