git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: stgit restrictions on patch names

From
CMCatalin Marinas <catalin.marinas@gmail.com>
Date
Oct 29, 2007, 16:14 UTC
Message-ID
<b0943d9e0710290914p4163ffabt5767fdb2ab8d91d4@mail.gmail.com>
In-Reply-To
<20071025194808.GV26436@nan92-1-81-57-214-146.fbx.proxad.net>
On 25/10/2007, Yann Dirson <ydirson@altern.org> wrote:
> Looks like stgit is now more picky on patch names than in used to be:

It's not that we explicitly disallows "+" but I think I tried to avoid some wrong patch names but was too lazy to create a better regexp.

As a quick fix, we could re-generate a patch name if it is invalid.
Show 10 quoted lines
> => the result of the cloning operation is a partial clone.  Do we want to:
>
> - implement a mechanism for checking beforehand that the operation
> will not fail ?  Seems awkward to duplicate checks already found
> elsewhere.
>
> - wait for proper transactions so we can rollback on error ?
>
> - on clone error, delete the newly-created stack ?  I'd vote for this
> one, until the previous one gets done.

I think the last one is the simplest to implement, while the second is nicer, I've never found the time to investigate it properly.

-- 
Catalin
Previous: Karl Hasselström
Message 3 of 3 in “stgit restrictions on patch names”
  1. Yann DirsonOct 25, 2007
  2. Karl HasselströmOct 26, 2007
  3. Catalin MarinasOct 29, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.