Re: [PATCH v2] builtin/blame: fix out-of-bounds read with excessive `--abbrev`

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 9, 2025, 13:43 UTC
Message-ID: <b09009f0-c822-f81d-1f79-07610ec20193@gmx.de>
In-Reply-To: <20250109-b4-pks-blame-truncate-hash-length-v2-1-589c81a6ddb0@pks.im>

Hi Patrick,

On Thu, 9 Jan 2025, Patrick Steinhardt wrote:

Show 10 quoted lines

> diff --git a/t/t8002-blame.sh b/t/t8002-blame.sh
> index 0147de304b4d104cc7f05ea1f8d68f1a07ceb80d..7cf6e0253a5bbd4d6e438e627dc18b47eac4df66 100755
> --- a/t/t8002-blame.sh
> +++ b/t/t8002-blame.sh
> @@ -126,6 +126,10 @@ test_expect_success '--no-abbrev works like --abbrev with full length' '
>  	check_abbrev $hexsz --no-abbrev
>  '
>
> +test_expect_success 'blame --abbrev gets truncated' '
> +	check_abbrev $hexsz --abbrev=9000 HEAD

Please note that the patch I proposed had `HEAD..` here, not `HEAD`. The latter would not have surfaced the problem with boundary commits.

Ciao, Johannes