Re: [PATCH] headers: Preserve 'change-id' header in rebase / cherry-pick.
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Nov 15, 2026, 16:24 UTC
- Message-ID
- <avnct0KGKN3a76lB@fruit.crustytoothpaste.net>
- In-Reply-To
- <GV4P192MB328727D81CAED2956E2C682BC07D2@GV4P192MB3287.EURP192.PROD.OUTLOOK.COM>
On 2026-11-15 at 11:03:05, Ewout ter Hoeven wrote:
Show 11 quoted lines
> On 2026-04-07 at 23:28, brian m. carlson wrote: > > Absent some well-defined documentation describing what it means, I don't > > see how it could provide good value. > > A concrete use case could be stacked pull/merge requests. > > GitHub's stacked PRs (CLI in github/gh-stack) and GitLab's experimental > "glab stack" both have to answer "is this rewritten commit the same > change as before?" after every rebase. Without an identity that > survives rewrites they guess from branch names, recorded bases and > patch IDs, and the guesses fail in practice:
I don't think that's going to be helpful there. Users can modify change-id headers in commits, so they can't be trusted as a source of unmodified data. Only if the server does the rebase can it have confidence that things haven't changed.
Otherwise, a malicious user could get a review on v1 of a series and send out a completely different v2 with the same change-ids such that the server would honour the existing review and accept the malicious code.
-- brian m. carlson (they/them) Toronto, Ontario, CA Speaking for myself only