git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] add -i: hide init/clear_add_i_state() functions

From
Patrick Steinhardt <ps@pks.im>
Date
Nov 2, 2026, 08:42 UTC
Message-ID
<auhM8Y8mkRMJOdjH@pks.im>
In-Reply-To
<EDD8FC7B-91B4-49CA-AE6B-3475E03EF786@gmail.com>
On Fri, Oct 30, 2026 at 05:35:20PM -0400, Ben Knoble wrote:
Show 32 quoted lines
> 
> > Le 30 oct. 2026 à 11:30, Junio C Hamano <gitster@pobox.com> a écrit :
> > 
> > Patrick Steinhardt <ps@pks.im> writes:
> > 
> >>> On Wed, Oct 28, 2026 at 12:57:51PM -0700, Junio C Hamano wrote:
> >>> The "add -i" machinery is encapsulated in run_add_i() function,
> >>> which uses init_add_i_state() to initialize the machinery, does its
> >>> thing, and clear_add_i_state() to tear it down.  External callers
> >>> have no need to call anything other than run_add_i().
> >>> 
> >>> Make init/clear_add_i_state() file-scope static functions, and
> >>> "struct add_i_state" type as well.
> >> 
> >> Nice cleanup. For historical context, these declarations are not needed
> >> anymore starting with d51b61f5dab (add-patch: remove dependency on
> >> "add-interactive" subsystem, 2026-03-02).
> > 
> > Thanks.  I did not notice that I gave a backstory for the other
> > three commits but apparently did so without digging into the history
> > for this one.
> > 
> > By the way, I queued the patches sent to the list on a branch (I
> > initially made them on a detached HEAD without keeping a local copy
> > after sending them out) and tried 'git history reword' to update
> > this one, but it seems it does not honor the notes.rewriteref
> > configuration variable.  I wonder if this is a known limitation, or
> > a deliberate design.
> 
> Indeed. I believe it is a known limitation (one I would love to
> lift, but will probably not dedicate time to produce code soon).
> Still, I’ll help in the usual ways if I can ;)

Yeah, it's a limitation and not a design decision. I'd be happy to review any such patch series, as I'm also a bit short on time recently. Meanwhile I've also created an issue in our bug tracker, so we may pick this up in the next release cycle.

Patrick
Previous: Ben Knoble
Message 6 of 6 in “add -i: hide init/clear_add_i_state() functions”
  1. add -i: hide init/clear_add_i_state() functionsJunio C Hamano, Oct 28, 2026
  2. Ben KnobleOct 28, 2026
  3. Patrick SteinhardtOct 30, 2026
  4. Junio C HamanoOct 30, 2026
  5. Ben KnobleOct 30, 2026
  6. Patrick SteinhardtNov 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.