git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] worktree: add --reflink for copy-on-write worktree creation

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Oct 22, 2026, 22:31 UTC
Message-ID
<atqOqRE866bgyxfL@fruit.crustytoothpaste.net>
In-Reply-To
<CAGou9MhkmSZs3ViSj6qqkZY6LLLQQ+5RzjLG5EhM-AXx+d7h=A@mail.gmail.com>
On 2026-10-21 at 07:15:50, Jason Newton wrote:
> Brian,
Hay,
Show 16 quoted lines
> macOS cp has no --reflink=always. The clone option is -c, which is
> clonefile(2). t/t2400-worktree-add.sh already probes that way. The
> REFLINK prerequisite runs "cp -c" when the MACOS prerequisite is set,
> and "cp --reflink=always" otherwise. The test that depends on REFLINK
> is "--reflink carries untracked files and reconciles changes".
> 
> That is in 042485f0e9cd8cf1765b811ea7334247aec44971. The pull request
> CI for that commit is the APFS run:
> 
> https://github.com/git/git/pull/2317
> https://github.com/git/git/actions/runs/39502233266
> 
> All four macos-14 jobs succeeded. The runners were macOS 14.8.9
> (23J631), image macos-14-arm64 20260831.0302.1. "print test failures"
> was skipped on each job, which is the step that runs only when a test
> script fails.

You have a test_lazy_prereq for REFLINK in your test file and it uses `cp --reflink=always`. If that doesn't work on macOS, then the prerequisite fails, so the test with the REFLINK prerequisite is skipped. That means it doesn't fail, but it also doesn't run, so it isn't testing anything at all.

What I'm saying is that it should actually pass the REFLINK prerequisite and run the test on macOS. It looks like you did do that in v3, which is good.

It also looks like at the very least substantial portions of this email are the output of an LLM. You should read and understand our AI policy[0]. In any event, I'm not going to review or respond further to AI slop, especially since I work on Git entirely in my personal time and my time is currently quite limited.

We consider it important to explain our patches and our thought process well on this list and we have high standards for inclusion—as we should—since many developers around the world depend on us. You're welcome to participate, but you should respond to other humans with your own words and thoughts, since we're giving you the same time and courtesy. If I wanted to know what an LLM thinks about what I have to say, I know where to find one—I wouldn't have asked.[1]

[0] https://git-scm.com/docs/SubmittingPatches#ai [1] For the avoidance of doubt, these em dashes are my own creation and come from my love of language and the fact that I have an English degree.

-- 
brian m. carlson (they/them)
Toronto, Ontario, CA
Previous: Jason NewtonNext: Jason Newton via GitGitGadget
Message 10 of 23 in “worktree: copy-on-write creation and shared-branch worktrees”
  1. 0/2 worktree: copy-on-write creation and shared-branch worktreesJason Newton via GitGitGadget, Jun 5, 2026
  2. 1/2 worktree: add --reflink for copy-on-write worktree creationJason Newton via GitGitGadget, Jun 5, 2026
  3. 2/2 worktree: allow sharing a checked-out branch across worktreesJason Newton via GitGitGadget, Jun 5, 2026
  4. brian m. carlsonJun 5, 2026
  5. Junio C HamanoJun 8, 2026
  6. 0/2 worktree: copy-on-write creation and ephemeral branchesJason Newton via GitGitGadget, Oct 20, 2026
  7. 1/2 worktree: add --reflink for copy-on-write worktree creationJason Newton via GitGitGadget, Oct 20, 2026
  8. brian m. carlsonOct 20, 2026
  9. Jason NewtonOct 21, 2026
  10. brian m. carlsonOct 22, 2026
  11. 2/2 worktree: reap ephemeral branches created by "worktree add"Jason Newton via GitGitGadget, Oct 20, 2026
  12. Eric SunshineOct 21, 2026
  13. Jason NewtonOct 21, 2026
  14. Eric SunshineOct 21, 2026
  15. Jason NewtonOct 21, 2026
  16. Phillip WoodOct 21, 2026
  17. Jason NewtonOct 21, 2026
  18. Eric SunshineOct 21, 2026
  19. 0/4 worktree: copy-on-write creation and ephemeral branchesJason Newton via GitGitGadget, Oct 21, 2026
  20. 1/4 worktree: add --reflink for copy-on-write worktree creationJason Newton via GitGitGadget, Oct 21, 2026
  21. 2/4 worktree: reap ephemeral branches created by "worktree add"Jason Newton via GitGitGadget, Oct 21, 2026
  22. 3/4 worktree: disable reflink on WindowsJason Newton via GitGitGadget, Oct 21, 2026
  23. 4/4 worktree: keep the reflink probe referenced on WindowsJason Newton via GitGitGadget, Oct 21, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.