git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/5] odb: remove read loop for found objects

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 14, 2026, 06:56 UTC
Message-ID
<as8niG1LrNqxfRzV@pks.im>
In-Reply-To
<as6kNufOqLFeBoNh@denethor>
On Tue, Oct 13, 2026 at 04:48:23PM -0500, Justin Tobler wrote:
Show 32 quoted lines
> On 26/10/13 09:36AM, Patrick Steinhardt wrote:
> > diff --git a/odb.c b/odb.c
> > index 69a4c203bc..095183aec0 100644
> > --- a/odb.c
> > +++ b/odb.c
> > @@ -265,7 +265,6 @@ static enum odb_read_status do_oid_object_info_extended(struct object_database *
> >  	struct strbuf corrupt_err = STRBUF_INIT;
> >  	const struct object_id *real = oid;
> >  	enum odb_read_status ret;
> > -	int already_retried = 0;
> >  	bool corrupt = false;
> >  
> >  	if (flags & OBJECT_INFO_LOOKUP_REPLACE)
> > @@ -277,38 +276,39 @@ static enum odb_read_status do_oid_object_info_extended(struct object_database *
> >  	if (!odb_source_read_object_info(odb->inmemory_objects, oid, oi, flags, NULL))
> >  		return 0;
> >  
> > -	while (1) {
> > +	ret = odb_source_read_object_info(odb->source, real, oi, flags,
> > +					  &corrupt_err);
> 
> Here is try to read the object, the backend is responsible for handling
> any retries internally that it cares about.
> 
> > +	if (!ret)
> > +		goto out;
> > +	if (ret != ODB_READ_NOT_FOUND)
> > +		corrupt = true;
> 
> If the repsitory is correct, does it even make sense to continue to try
> and fetch the missing object? I wonder if we should set `ret =
> ODB_READ_ERROR` and `goto out`?

I think I tend to agree. I don't want to do it as part of this commit though, which is a plain refactoring that shouldn't change semantics. I'll add a commit on top though.

Patrick
Previous: Justin ToblerNext: Justin Tobler
Message 12 of 37 in “odb/files: cleanups and improvements for alternates”
  1. 0/5 odb/files: cleanups and improvements for alternatesPatrick Steinhardt, Oct 13, 2026
  2. 1/5 odb/source-files: fix performance when reading objects with alternatesPatrick Steinhardt, Oct 13, 2026
  3. Justin ToblerOct 13, 2026
  4. 2/5 odb/source-files: fix performance when streaming objects with alternatesPatrick Steinhardt, Oct 13, 2026
  5. Justin ToblerOct 13, 2026
  6. 3/5 odb/source-files: make the second read an implementation detailPatrick Steinhardt, Oct 13, 2026
  7. Justin ToblerOct 13, 2026
  8. Patrick SteinhardtOct 14, 2026
  9. Justin ToblerOct 14, 2026
  10. 4/5 odb: remove read loop for found objectsPatrick Steinhardt, Oct 13, 2026
  11. Justin ToblerOct 13, 2026
  12. Patrick SteinhardtOct 14, 2026
  13. Justin ToblerOct 14, 2026
  14. 5/5 odb/source: drop `local` flagPatrick Steinhardt, Oct 13, 2026
  15. Justin ToblerOct 13, 2026
  16. Patrick SteinhardtOct 14, 2026
  17. Justin ToblerOct 14, 2026
  18. Patrick SteinhardtOct 15, 2026
  19. 0/6 odb/files: cleanups and improvements for alternatesPatrick Steinhardt, Oct 14, 2026
  20. 1/6 odb/source-files: fix performance when reading objects with alternatesPatrick Steinhardt, Oct 14, 2026
  21. Johannes SchindelinOct 14, 2026
  22. Patrick SteinhardtOct 14, 2026
  23. 2/6 odb/source-files: fix performance when streaming objects with alternatesPatrick Steinhardt, Oct 14, 2026
  24. 3/6 odb/source-files: make the second read an implementation detailPatrick Steinhardt, Oct 14, 2026
  25. 4/6 odb: remove read loop for found objectsPatrick Steinhardt, Oct 14, 2026
  26. 5/6 odb: don't try re-fetching corrupt objectsPatrick Steinhardt, Oct 14, 2026
  27. Justin ToblerOct 14, 2026
  28. 6/6 odb/source: drop `local` flagPatrick Steinhardt, Oct 14, 2026
  29. 0/6 odb/files: cleanups and improvements for alternatesPatrick Steinhardt, Oct 15, 2026
  30. 1/6 odb/source-files: fix performance when reading objects with alternatesPatrick Steinhardt, Oct 15, 2026
  31. 2/6 odb/source-files: fix performance when streaming objects with alternatesPatrick Steinhardt, Oct 15, 2026
  32. 3/6 odb/source-files: make the second read an implementation detailPatrick Steinhardt, Oct 15, 2026
  33. 4/6 odb: remove read loop for found objectsPatrick Steinhardt, Oct 15, 2026
  34. 5/6 odb: don't try re-fetching corrupt objectsPatrick Steinhardt, Oct 15, 2026
  35. 6/6 odb/source: drop `local` flagPatrick Steinhardt, Oct 15, 2026
  36. Justin ToblerOct 15, 2026
  37. Junio C HamanoOct 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.