Re: [PATCH] builtin/repo: rename "references.format" to "references.storageFormat"
- From
Justin Tobler <jltobler@gmail.com>
- Date
- Oct 13, 2026, 22:50 UTC
- Message-ID
- <as61Dh7ui54gdzGV@denethor>
- In-Reply-To
- <20261005-pks-repo-ref-storage-format-v1-1-819a181572a9@pks.im>
On 26/10/05 12:14PM, Patrick Steinhardt wrote:
Show 7 quoted lines
> As part of 2f28db44d5 (Merge branch 'ps/ref-storage-format', 2026-10-01) > we have adapt all sites that used to say "reference format" to instead > say "reference storage format". > > One missed spot though was in git-repo(1), where we still print the > "references.format" key. Fix that oversight by renaming the key to > "references.storageFormat".
Being that git-repo(1) is a recent command and still marked as experimental, I think making this change to be consistent is completely reasonable. It makes sense to keep the naming unified.
Show 54 quoted lines
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> Hi,
>
> this is a follow-up on 2f28db44d5 (Merge branch 'ps/ref-storage-format',
> 2026-10-01), where I missed this one place. I noticed that only today
> while working on the object storage format extension.
>
> Thanks!
>
> Patrick
> ---
> Documentation/git-repo.adoc | 6 +++---
> builtin/repo.c | 2 +-
> t/t1900-repo-info.sh | 12 ++++++------
> 3 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/git-repo.adoc b/Documentation/git-repo.adoc
> index ed7d80c690..5af454e8ca 100644
> --- a/Documentation/git-repo.adoc
> +++ b/Documentation/git-repo.adoc
> @@ -119,7 +119,7 @@ values that they return:
> `path.gitdir.relative`::
> The path to the Git repository directory relative to the current working directory.
>
> -`references.format`::
> +`references.storageFormat`::
> The reference storage format. The valid values are:
> +
> include::ref-storage-format.adoc[]
> @@ -127,10 +127,10 @@ include::ref-storage-format.adoc[]
> EXAMPLES
> --------
>
> -* Retrieves the reference format of the current repository:
> +* Retrieves the reference storage format of the current repository:
> +
> ------------
> -git repo info references.format
> +git repo info references.storageFormat
> ------------
> +
>
> diff --git a/builtin/repo.c b/builtin/repo.c
> index 84e012f83f..15267e8d54 100644
> --- a/builtin/repo.c
> +++ b/builtin/repo.c
> @@ -137,7 +137,7 @@ static const struct repo_info_field repo_info_field[] = {
> { "path.commondir.relative", get_path_commondir_relative },
> { "path.gitdir.absolute", get_path_gitdir_absolute },
> { "path.gitdir.relative", get_path_gitdir_relative },
> - { "references.format", get_references_format },
> + { "references.storageFormat", get_references_format },Here we change the key name. The rest of this patch looks trivially correct.
-Justin