Re: [PATCH] name-rev: update hash descriptions
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Sep 27, 2026, 22:34 UTC
- Message-ID
- <armZ28MWl9dTHDz6@fruit.crustytoothpaste.net>
- In-Reply-To
- <20260927194602.86750-1-jyotishkumar725015@gmail.com>
On 2026-09-27 at 19:46:02, jyotish kumar wrote:
Show 33 quoted lines
> The documentation for --annotate-stdin and --name-only refers to > SHA-1, although name-rev handles object IDs according to the active > hash algorithm. > > Update the descriptions to refer to object IDs instead. > > Signed-off-by: jyotish kumar <jyotishkumar725015@gmail.com> > --- > Documentation/git-name-rev.adoc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/git-name-rev.adoc b/Documentation/git-name-rev.adoc > index d4f1c4d594..9837fe59b3 100644 > --- a/Documentation/git-name-rev.adoc > +++ b/Documentation/git-name-rev.adoc > @@ -43,7 +43,7 @@ OPTIONS > List all commits reachable from all refs > > --annotate-stdin:: > - Transform stdin by substituting all the 40-character SHA-1 > + Transform stdin by substituting all the full-length object ID > hexes (say $hex) with "$hex ($rev_name)". When used with > --name-only, substitute with "$rev_name", omitting $hex > altogether. This option was called `--stdin` in older versions > @@ -72,7 +72,7 @@ while its tree object is 70d105cc79e63b81cfdcb08a15297c23e60b07ad > ----------- > > --name-only:: > - Instead of printing both the SHA-1 and the name, print only > + Instead of printing both the object ID and the name, print only > the name. If given with --tags the usual tag prefix of > "tags/" is also omitted from the name, matching the output > of `git-describe` more closely.
This looks much better. I didn't see any other instances of "SHA-1" in the documentation or "40", so this looks complete.
-- brian m. carlson (they/them) Toronto, Ontario, CA