git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] ci: drop no-op gettext link on macOS

From
Patrick Steinhardt <ps@pks.im>
Date
Sep 14, 2026, 06:25 UTC
Message-ID
<aqeTas30Vs3aGE9D@pks.im>
In-Reply-To
<pull.2402.git.git.1789199739368.gitgitgadget@gmail.com>
On Sat, Sep 12, 2026 at 07:55:39AM +0000, Harald Nordgren via GitGitGadget wrote:
Show 5 quoted lines
> From: Harald Nordgren <haraldnordgren@gmail.com>
> 
> gettext ships already linked on the macOS CI runner image, so this
> command never links anything. It only emits a spurious "Already
> linked" warning in every macOS job's log.

I feel like this is oversimplifying things a bit. The commit message doesn't explain why we even orignially had it, and consequently it's not really explaining why we don't anymore.

The gettext dependency in Homebrew is keg-only, which means that it will typically never be linked anywhere visible into your system. Instead, it is only being installed into your Homebrew cellar, which means that it will not interfer with anything. And trying to link such a dependency will not do anything, as Homebrew refuses such an operation.

By using `brew link --force` though you override that and thus override any system-provided equivalents by symlinking the dependency into a central place. Now the question is whether this is still needed. But that question is not answered by your commit message. The warning that you mention is this one:

  + brew link --force gettext
  ✔︎ JSON API formula_tap_migrations.jws.json
  ✔︎ JSON API cask_tap_migrations.jws.json
  Warning: Already linked: /opt/homebrew/Cellar/gettext/1.0
  To relink, run:
    brew unlink gettext && brew link gettext

But that warning only complains that gettext is already linked into your cellar. It does not say whether it may have linked the library into your system's path now.

So I'm still left wondering whether it really isn't required anymore, and if so why it stopped being required. Links to passing GitHub and GitLab pipelines with that change would've in this case also helped to demonstrate that it works without that line.

Thanks!
Patrick
Previous: Harald Nordgren via GitGitGadgetNext: Harald Nordgren
Message 2 of 11 in “ci: drop no-op gettext link on macOS”
  1. ci: drop no-op gettext link on macOSHarald Nordgren via GitGitGadget, Sep 12, 2026
  2. Patrick SteinhardtSep 14, 2026
  3. Harald NordgrenSep 14, 2026
  4. Patrick SteinhardtSep 14, 2026
  5. Harald NordgrenSep 14, 2026
  6. Harald NordgrenOct 23, 2026
  7. Patrick SteinhardtOct 26, 2026
  8. ci: drop no-op gettext link on macOSHarald Nordgren via GitGitGadget, Sep 14, 2026
  9. Junio C HamanoSep 26, 2026
  10. Harald NordgrenSep 26, 2026
  11. Patrick SteinhardtOct 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.