Re: [PATCH 0/2] doc: refs: put ref migration warning under the command
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Aug 4, 2026, 14:30 UTC
- Message-ID
- <anH3oN3JRaG1eEfK@pks.im>
- In-Reply-To
- <xmqqbjbncdv5.fsf@gitster.g>
On Fri, Jul 31, 2026 at 09:39:42AM -0700, Junio C Hamano wrote:
Show 16 quoted lines
> kristofferhaugsbakk@fastmail.com writes: > > > From: Kristoffer Haugsbakk <code@khaugsbakk.name> > > > > Topic name: doc-refs-migrate-limitations > > > > Topic summary: Put ref migration warning as an admonition under the command > > so that it is visible. > > The caveat only applies to the "migrate" subcommand, and the new > placement gives us a much better logical organization. > > > That’s the first patch. The second patch adds a missing `linkgit` since it > > touches that same warning text. > > Looks good. Thanks.
Both patches look good to me. The indentation feels one level too deep on the firstr patch, but this is a tiny nitpick that we may not even want to address in the first place.
Thanks!
Patrick