Re: [GSoC PATCH] submodule: warn on valueless active config

From: Weijie Yuan <wy@wyuan.org>
Date: Aug 14, 2026, 17:56 UTC
Message-ID: <an9W4XwY8X4ZFHpA@wyuan.org>
In-Reply-To: <CABB4Jh3UUXvmAJpefaiP-xVRQfGRdTF2jW8GkdhbA1BXe6Okdw@mail.gmail.com>

On Fri, Aug 14, 2026 at 11:07:29PM +0530, Tilak Raaz wrote:

Show 16 quoted lines

> Hi everyone,
> 
> My name is Tilak  (he/him), and I am a second-year Electronics and
> Instrumentation Engineering student at NIT Rourkela. I am preparing to
> apply for GSoC 2027 and am starting my contributions to Git.
> 
> Regarding my background with Git: I have built Git from source,
> successfully
> navigated the codebase, and tackled the NEEDSWORK comment regarding
> valueless 'submodule.active' configurations in submodule.c.
> 
> Below is my microproject patch resolving this issue by switching from
> repo_config_get_string_multi() to repo_config_get_value_multi() and
> adding an automated test case in t7400-submodule-basic.sh.
> 
> I look forward to your feedback!

Thanks!

However, my suggestion is that it would be better to place your patch in the main body of the email text rather than in the attachment. Please take a look at Documentation/SubmittingPatches [[attachment]]

And it also seems that the automated program 'b4' is unable to recognize your patch, which may make the development process less convenient for the developers and the maintainer.

$ b4 am https://lore.kernel.org/git/CABB4Jh3UUXvmAJpefaiP-xVRQfGRdTF2jW8GkdhbA1BXe6Okdw@mail.gmail.com/ Looking up CABB4Jh3UUXvmAJpefaiP-xVRQfGRdTF2jW8GkdhbA1BXe6Okdw@mail.gmail.com Analyzing 1 messages in the thread No patches found.

Please correct me if I'm wrong.

Thanks.