Re: [PATCH] gitweb: Strip non-printable characters from syntax highlighter output

From: Christopher M. Fuhrman <cfuhrman@panix.com>
Date: Sep 16, 2011, 18:11 UTC
Message-ID: <alpine.NEB.2.01.1109161050080.2073@vc75.vc.panix.com>
In-Reply-To: <201109161441.58946.jnareb@gmail.com>

Howdy,

On Fri, 16 Sep 2011 at 5:41am, Jakub Narebski wrote:

Show 5 quoted lines

> The commit message is from Christopher, but I have replaced his solution
> of stripping non-printable characters via col(1) program by having gitweb
> strip characters not allowed in XML.
>
> Christopher, could you check that it fixes your issue?

After applying the patch, I tested it successfully against the following files:

 * linux.git : arch/ia64/kernel/unwind.c
 * git.git   : t/t3902-quoted.sh

Furthermore, I'm pleased to report that non en_US.UTF8 characters (e.g., Chinese hanzi) as found in t3902-quoted.sh are displayed properly when highlight is enabled.

Tested Web Browsers:

 * Safari (5.1 (6534.50)
 * Firefox 6.0.2 under Mac OS X Snow Leopard
 * Google Chrome 13.0.782.220 under OpenSuSE 11.4

>
>  gitweb/gitweb.perl |   14 +++++++++++++-
>  1 files changed, 13 insertions(+), 1 deletions(-)
>

Cheers!

-- 
Chris Fuhrman
cfuhrman@panix.com