Re: What's cooking in git.git (Jul 2015, #01; Wed, 1)

From: Tony Finch <dot@dotat.at>
Date: Jul 22, 2015, 13:19 UTC
Message-ID: <alpine.LSU.2.00.1507221351420.12758@hermes-1.csi.cam.ac.uk>
In-Reply-To: <55AF7B9C.4000108@gmail.com>

Jakub Narębski <jnareb@gmail.com> wrote:

>
> A question about implementation: why emptying $path_info in
> evaluate_path_info()?

That was for consistency with other parts of the subroutine which (mostly) remove items from the global $path_info variable when they are added to %input_params. But since $path_info isn't used after it has been parsed, I suppose it is redundant.

Show 15 quoted lines

> >> - I think that people would want to be able to configure how
> >>   many levels of directory hierarchy gets turned into categories.
> >>   Perhaps only top level should be turned into category? Deep
> >>   hierarchies means deep categories (usually with very few
> >>   repositories) with current implementation.
> >
> > Good question. I was assuming flat-ish directory hierarchies, but that's
> > clearly not very true, e.g. https://git.kernel.org/cgit/
> >
> > I think it would be right to make this a %feature since categories already
> > nearly fit the %feature per-project override style.
>
> On the other hand $projects_list_group_categories is a global gitweb
> configuration variable, and $projects_list_directory_is_category was
> patterned after it.

Yes... Which do you prefer? :-)

> A few thoughts about implementation:

Helpful, thanks!

> - can we turn category header into link even if the category didn't
>   came from $projects_list_directory_is_category?

That would mean changing the project filter to match categories as well as paths. I don't know if this is the right thing to do; perhaps it is, because the current behaviour of my category headings is a bit surprising.

At the moment, clicking on the "git" category heading on the page linked below takes you to a page that does not list all the repos that were under the category heading on the main page.

https://git.csx.cam.ac.uk/x/ucs/

> - even if $projects_list_directory_is_category is true, the category
>   could came from 'category' file, or otherwise manually set category,
>   though I wonder how we can easily detect this...

Yes - I use this to list my personal/experimental repos alongside the production repos.

I'm not sure why gitweb would need to detect this or what it would do in response. At the moment it "just works", apart from the oddity with categories vs project filters i described above.

Tony.

-- 
f.anthony.n.finch  <dot@dotat.at>  http://dotat.at/
Viking, North Utsire: Westerly 4 or 5, occasionally 6 at first, backing
southerly 3 or 4. Moderate becoming slight. Occasional rain in north. Good,
occasionally moderate.