Re: [PATCH] gitweb: Update logo and favicon
- From
Tony Finch <dot@dotat.at>
- Date
- Apr 13, 2015, 09:52 UTC
- Message-ID
- <alpine.LSU.2.00.1504131033420.23307@hermes-1.csi.cam.ac.uk>
- In-Reply-To
- <1428882040-13938-1-git-send-email-thosch97@gmail.com>
Thomas Schneider <thosch97@gmail.com> wrote:
Show 6 quoted lines
> The new images were downloaded from https://git-scm.herokuapp.com/downloads/logos > and converted with ImageMagick: > convert -resize 72x30 Git-Logo-2Color.eps git-logo.png > convert -resize 16x16 Git-Icon-1788C.eps git-favicon.png > The old logo was only 27 pixels in height, the 3 additional pixels are necessary > for the slightly different aspect ratio of the new one.
This is a good improvement :-) I did something similar for the logos on my installation of gitweb, including exactly the same command to create the favicon.
https://git.csx.cam.ac.uk/x/ucs/git/gitcam.git/blob/HEAD:/bin/make-icons.sh
I think it is a bad idea to change the height of the logo: gitweb generates an <img src> element with a fixed 72x27 size, and the gitweb.conf documentation suggests that site admins can replace the logo with a custom one of the same size. My version of the new logo includes a bit of horizontal padding so that it matches this specification.
(The higher-resolution icons are used by my server's documentation pages but not by gitweb.)
Tony.
-- f.anthony.n.finch <dot@dotat.at> http://dotat.at/ Humber, Thames: Northwest backing south or southwest later, 4 or 5, occasionally 6 later. Slight or moderate. Fair. Moderate or good.