Re: [PATCH] New test for preserve merges and squash

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 20, 2008, 11:09 UTC
Message-ID: <alpine.LSU.1.00.0803201208080.3983@racer.site>
In-Reply-To: <20080320101809.GA23108@alea.gnuu.de>

Hi,

On Thu, 20 Mar 2008, Jörg Sommer wrote:

Show 15 quoted lines

> Junio C Hamano schrieb am Wed 19. Mar, 17:28 (-0700):
> > Jörg Sommer <joerg@alea.gnuu.de> writes:
> > 
> > > Signed-off-by: Jörg Sommer <joerg@alea.gnuu.de>
> > > ---
> > >  t/t3404-rebase-interactive.sh |   20 ++++++++++++++++++++
> > >  1 files changed, 20 insertions(+), 0 deletions(-)
> > >
> > > The current version of git fails this test. I think it's a bug, 
> > > because the patch is what I expect to happen. Or am I wrong?
> > 
> > Please mark such tests with test_expect_fail.
> 
> No, I expect the test succeeds. Currently, it fails. This might be, 
> because my expectations are wrong or there's a bug.

The definition of "test_expect_fail" is: this should succeed, but needs fixin'.

Show 5 quoted lines

> > And also Cc: the guilty parties.
> 
> Okay, I've added Johannes the author of f09c9b8c5ff to the Cc: list.
> 
> Johannes, can you explain why this test fails?

At the moment, I can't, because I indeed missed your original mail. Maybe I'll find time this afternoon to dive into gmane to find your original mail.

Ciao, Dscho