Re: I: git-fetch: -n option disappeared but git-fetch(1) still describe it

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 12, 2008, 16:04 UTC
Message-ID: <alpine.LSU.1.00.0803121703010.1656@racer.site>
In-Reply-To: <47D7EE27.50407@op5.se>

Hi,

On Wed, 12 Mar 2008, Andreas Ericsson wrote:

Show 18 quoted lines

> Dmitry V. Levin wrote:
> 
> > git-fetch builtinification (commit v1.5.3.2-93-gb888d61) apparently 
> > dropped -n option (alias to --no-tags) documented in 
> > Documentation/fetch-options.txt
> > 
> > Either builtin-fetch.c or Documentation/fetch-options.txt should be 
> > adjusted to sync the code with its docs.
> > 
> > Original bug report: 
> > https://bugzilla.altlinux.org/show_bug.cgi?id=14870
> 
> I have a (very) vague memory that git-fetch.sh had to iterate over tags 
> one by one, making tag-heavy projects excruciatingly slow to fetch from 
> with the shellscript version. Some pathological case with 2700 tags was 
> presented where a fetch took nearly an hour, iirc. AFAIR, the 
> builtinification (or was it a protocol extension?) reduced that time to 
> something around 10 seconds for the pathological case.

AFAIR this was helped by the fetch--tool helper, even at the time of non-builtin fetch.

> Does anyone else have a sharper memory of what caused the -n option to 
> be dropped?

AFAICT this was done because of the parsopt'ification. But I forgot the details.

Hth, Dscho