Re: [PATCH v2] Configure test for FREAD_READS_DIRECTORIES

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 4, 2008, 13:43 UTC
Message-ID: <alpine.LSU.1.00.0803041332580.22527@racer.site>
In-Reply-To: <alpine.LSU.1.00.0803041204490.22527@racer.site>

Hi,

On Tue, 4 Mar 2008, Johannes Schindelin wrote:

> I will test on msysGit in a moment.

Unfortunately, "autoconf" does not work in msysGit at the moment.

However, applying this patch on Linux, extracting the product of "make dist" on msysGit, and running "./configure" yields this:

... checking whether system succeeds to read fopen'ed directory... yes ...

And indeed, FREAD_READS_DIRECTORIES is set in config.mak.autogen. However, "f" was NULL in your test, so I am not quite sure what is going wrong...

Besides, you miss a return 0 in the end, I think. Or even better: you should

	return f && fread(&c, 1, 1, f);

BTW the commit message looks like this here... not nice (the commit log is not a mailing list):

commit 67418ff5d4f548f7de23e97bf165a8529ebf6a31
Author: Michal Rokos <michal.rokos@nextsoft.cz>
Date:   Tue Mar 4 12:44:11 2008 +0100

    Configure test for FREAD_READS_DIRECTORIES

    Hello,

    this patch adds missing tests for FREAD_READS_DIRECTORIES.

    Could anyone volunteer to test it on different platforms?
    So far I know it works well on Linux (no FREAD_READS_DIRECTORIES),
    HP-UXes 11.11 and 11.23 (FREAD_READS_DIRECTORIES defined).

    Thanks

MR

    Signed-off-by: Michal Rokos <michal.rokos@nextsoft.cz>

Ciao, Dscho