Re: [PATCH] Fix make_absolute_path() for parameters without a slash

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 2, 2008, 07:31 UTC
Message-ID: <alpine.LSU.1.00.0803020730170.22527@racer.site>
In-Reply-To: <alpine.LSU.1.00.0803020717060.22527@racer.site>

Hi,

On Sun, 2 Mar 2008, Johannes Schindelin wrote:

Show 12 quoted lines

> diff --git a/path.c b/path.c
> index 4260952..bf3e469 100644
> --- a/path.c
> +++ b/path.c
> @@ -311,8 +311,10 @@ const char *make_absolute_path(const char *path)
>  			if (last_slash) {
>  				*last_slash = '\0';
>  				last_elem = xstrdup(last_slash + 1);
> -			} else
> +			} else {
> +				*buf = '\0';
>  				last_elem = xstrdup(buf);

Oh, my. The *buf = '\0' must come _after the assignment to last_elem, of course.

Will stop posting patches for today, and fix tomorrow.

Ciao, Dscho