Re: [PATCH] Documentation/git svn log: add a note about timezones.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 27, 2008, 12:33 UTC
Message-ID: <alpine.LSU.1.00.0802271231080.22527@racer.site>
In-Reply-To: <20080227122929.GS31441@genesis.frugalware.org>

Hi,

On Wed, 27 Feb 2008, Miklos Vajna wrote:

> git svn log mimics the timezone converting behaviour of svn log, but this was

This line is definitely too long. Please make commit messages readable on an 80-character display with a 4-character indent, i.e. 76 characters/line.

Show 13 quoted lines

> On Wed, Feb 27, 2008 at 10:40:37AM +0000, Johannes Schindelin 
> <Johannes.Schindelin@gmx.de> wrote:
> > Note: if all you want is such a strange behaviour as svn's (I mean, 
> > why does it insist to show the dates as if they were done in _your_ 
> > timezone?):
> >
> >       git log --date=local
> >
> > > Is it documented anywhere?
> >
> > AFAICT it waits to be written.  By you.
> 
> something like this?

Yes, very nice. Although I find it sad that an opportunity was lost for a complainer to make good.

Show 15 quoted lines

> diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
> index 340f1be..e1babf3 100644
> --- a/Documentation/git-svn.txt
> +++ b/Documentation/git-svn.txt
> @@ -160,6 +160,10 @@ New features:
>  --
>  +
>  Any other arguments are passed directly to `git log'
> ++
> +NOTE: SVN itself only stores times in UTC and nothing else. The regular svn
> +client converts the UTC time to the local time (or based on the TZ=
> +environment). This command has the same behaviour.
>  
>  'blame'::
>         Show what revision and author last modified each line of a file. This is

I think that this note should come before the "Any other arguments" line.

Ciao, Dscho