Re: [PATCH] git-clone.sh: properly configure remote even if remote's head is dangling

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 20, 2008, 15:18 UTC
Message-ID: <alpine.LSU.1.00.0802201516570.17164@racer.site>
In-Reply-To: <20080220151017.17840.qmail@767a223c93e1c8.315fe32.mid.smarden.org>

Hi,

On Wed, 20 Feb 2008, Gerrit Pape wrote:

Show 6 quoted lines

> When cloning a remote repository which's HEAD refers to a nonexistent 
> ref, git-clone cloned all existing refs, but failed to write the 
> configuration for 'remote'.  Now it detects the dangling remote HEAD, 
> refuses to checkout any local branch since HEAD refers to nowhere, but 
> properly writes the configuration for 'remote', so that subsequent 'git 
> fetch's don't fail.

I like your reasoning, and your patch.  Except maybe...

Show 10 quoted lines

> diff --git a/t/t5701-clone-local.sh b/t/t5701-clone-local.sh
> index 822ac8c..59a165a 100755
> --- a/t/t5701-clone-local.sh
> +++ b/t/t5701-clone-local.sh
> @@ -63,4 +63,12 @@ test_expect_success 'Even without -l, local will make a hardlink' '
>  	test 0 = $copied
>  '
>  
> +test_expect_success 'local clone of repo with nonexistent ref in HEAD' '
> +	cd "$D" &&

... making this a subshell would be nice, so that subsequent tests start out from trash/ again?

Ciao, Dscho