Re: [PATCH 2/4] Export some email and pretty-printing functions

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 18, 2008, 12:44 UTC
Message-ID: <alpine.LSU.1.00.0802181241440.30505@racer.site>
In-Reply-To: <alpine.LNX.1.00.0802171335460.5816@iabervon.org>

Hi,

On Sun, 17 Feb 2008, Daniel Barkalow wrote:

Show 23 quoted lines

> diff --git a/commit.h b/commit.h
> index 10e2b5d..42b4825 100644
> --- a/commit.h
> +++ b/commit.h
> @@ -71,6 +71,21 @@ extern void pretty_print_commit(enum cmit_fmt fmt, const struct commit*,
>                                  int abbrev, const char *subject,
>                                  const char *after_subject, enum date_mode,
>  				int non_ascii_present);
> +void add_user_info(const char *what, enum cmit_fmt fmt, struct strbuf *sb,
> +		   const char *line, enum date_mode dmode,
> +		   const char *encoding);
> +void pp_title_line(enum cmit_fmt fmt,
> +		   const char **msg_p,
> +		   struct strbuf *sb,
> +		   const char *subject,
> +		   const char *after_subject,
> +		   const char *encoding,
> +		   int plain_non_ascii);
> +void pp_remainder(enum cmit_fmt fmt,
> +		  const char **msg_p,
> +		  struct strbuf *sb,
> +		  int indent);
> +

In addition to Junio's concern that add_user_info() really wants to be called pp_add_user_info(), I cannot help myself but suspect that pp_write_email_headers() -- which called for a new name, too -- also wants to live in pretty.c.

Ciao, Dscho