Re: [PATCH 1/5] Add platform-independent .git "symlink"

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 18, 2008, 11:45 UTC
Message-ID: <alpine.LSU.1.00.0802181144270.30505@racer.site>
In-Reply-To: <8c5c35580802180035q3d914720x54aa7e32d6e82108@mail.gmail.com>

Hi,

On Mon, 18 Feb 2008, Lars Hjemli wrote:

Show 11 quoted lines

> On Feb 18, 2008 6:43 AM, Junio C Hamano <gitster@pobox.com> wrote:
> > Lars Hjemli <hjemli@gmail.com> writes:
> >
> > > +/*
> > > +     if (!is_git_directory(buf + 8))
> > > +             return NULL;
> > > +*/
> >
> > Likewise.
> 
> True, I'll uncomment and die().

Hmm.  From check_repository_format_gently():

		if (!nongit_ok)
                        die ("...")
		warning("Expected git repo version <= %d...");

I think we want that, too.  (die() when !nongit_ok, but warn otherwise)

Ciao, Dscho